Commit 1e837861 authored by Ulf Hansson's avatar Ulf Hansson Committed by Rafael J. Wysocki
Browse files

PM / runtime: Fixup reference counting of device link suppliers at probe 



In the driver core, before it invokes really_probe() it runtime resumes the
suppliers for the device via calling pm_runtime_get_suppliers(), which also
increases the runtime PM usage count for each of the available supplier.

This makes sense, as to be able to allow the consumer device to be probed
by its driver. However, if the driver decides to add a new supplier link
during ->probe(), hence updating the list of suppliers, the following call
to pm_runtime_put_suppliers(), invoked after really_probe() in the driver
core, we get into trouble.

More precisely, pm_runtime_put() gets called also for the new supplier(s),
which is wrong as the driver core, didn't trigger pm_runtime_get_sync() to
be called for it in the first place. In other words, the new supplier may
be runtime suspended even in cases when it shouldn't.

Fix this behaviour, by runtime resume suppliers according to the same
conditions as managed by the runtime PM core, when runtime resume callbacks
are being invoked.

Additionally, don't try to runtime suspend any of the suppliers after
really_probe(), but instead rely on that to happen via the consumer device,
when it becomes runtime suspended.

Fixes: 21d5c57b (PM / runtime: Use device links)
Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 21c73367

drivers/base/dd.c

+1 −2
Original line number Diff line number Diff line
@@ -580,7 +580,7 @@ int driver_probe_device(struct device_driver *drv, struct device *dev) 
	pr_debug("bus: '%s': %s: matched device %s with driver %s\n",

		 drv->bus->name, __func__, dev_name(dev), drv->name);



	pm_runtime_get_suppliers(dev);

	pm_runtime_resume_suppliers(dev);

	if (dev->parent)

		pm_runtime_get_sync(dev->parent);
@@ -591,7 +591,6 @@ int driver_probe_device(struct device_driver *drv, struct device *dev) 
	if (dev->parent)

		pm_runtime_put(dev->parent);



	pm_runtime_put_suppliers(dev);

	return ret;

}

drivers/base/power/runtime.c

+3 −24
Original line number Diff line number Diff line
@@ -1563,37 +1563,16 @@ void pm_runtime_clean_up_links(struct device *dev) 
}



/**

 * pm_runtime_get_suppliers - Resume and reference-count supplier devices.

 * pm_runtime_resume_suppliers - Resume supplier devices.

 * @dev: Consumer device.

 */

void pm_runtime_get_suppliers(struct device *dev)

void pm_runtime_resume_suppliers(struct device *dev)

{

	struct device_link *link;

	int idx;



	idx = device_links_read_lock();



	list_for_each_entry_rcu(link, &dev->links.suppliers, c_node)

		if (link->flags & DL_FLAG_PM_RUNTIME)

			pm_runtime_get_sync(link->supplier);



	device_links_read_unlock(idx);

}



/**

 * pm_runtime_put_suppliers - Drop references to supplier devices.

 * @dev: Consumer device.

 */

void pm_runtime_put_suppliers(struct device *dev)

{

	struct device_link *link;

	int idx;



	idx = device_links_read_lock();



	list_for_each_entry_rcu(link, &dev->links.suppliers, c_node)

		if (link->flags & DL_FLAG_PM_RUNTIME)

			pm_runtime_put(link->supplier);

	rpm_get_suppliers(dev);



	device_links_read_unlock(idx);

}

include/linux/pm_runtime.h

+2 −4
Original line number Diff line number Diff line
@@ -56,8 +56,7 @@ extern void pm_runtime_update_max_time_suspended(struct device *dev, 
						 s64 delta_ns);

extern void pm_runtime_set_memalloc_noio(struct device *dev, bool enable);

extern void pm_runtime_clean_up_links(struct device *dev);

extern void pm_runtime_get_suppliers(struct device *dev);

extern void pm_runtime_put_suppliers(struct device *dev);

extern void pm_runtime_resume_suppliers(struct device *dev);

extern void pm_runtime_new_link(struct device *dev);

extern void pm_runtime_drop_link(struct device *dev);
@@ -173,8 +172,7 @@ static inline unsigned long pm_runtime_autosuspend_expiration( 
static inline void pm_runtime_set_memalloc_noio(struct device *dev,

						bool enable){}

static inline void pm_runtime_clean_up_links(struct device *dev) {}

static inline void pm_runtime_get_suppliers(struct device *dev) {}

static inline void pm_runtime_put_suppliers(struct device *dev) {}

static inline void pm_runtime_resume_suppliers(struct device *dev) {}

static inline void pm_runtime_new_link(struct device *dev) {}

static inline void pm_runtime_drop_link(struct device *dev) {}

CRA Git | Maintained and supported by SUSTech CRA and CCSE