Commit 1e630665 authored Apr 20, 2018 by Ian Kent Committed by Linus Torvalds Apr 20, 2018

autofs: mount point create should honour passed in mode

The autofs file system mkdir inode operation blindly sets the created
directory mode to S_IFDIR | 0555, ingoring the passed in mode, which can
cause selinux dac_override denials.

But the function also checks if the caller is the daemon (as no-one else
should be able to do anything here) so there's no point in not honouring
the passed in mode, allowing the daemon to set appropriate mode when
required.

Link: http://lkml.kernel.org/r/152361593601.8051.14014139124905996173.stgit@pluto.themaw.net


Signed-off-by: Ian Kent <raven@themaw.net>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 1551cf74

fs/autofs4/root.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -749,7 +749,7 @@ static int autofs4_dir_mkdir(struct inode *dir,

		autofs4_del_active(dentry);

		inode = autofs4_get_inode(dir->i_sb, S_IFDIR \| 0555);
		inode = autofs4_get_inode(dir->i_sb, S_IFDIR \| mode);
		if (!inode)
		return -ENOMEM;
		d_add(dentry, inode);

Admin message