Commit 1e612a0f authored by Ville Syrjälä's avatar Ville Syrjälä
Browse files

drm/sun4i: Eliminate pointless on stack copy of drm_display_info 



Just use a pointer to the display_info rather than make a copy
on stack.

Cc: Maxime Ripard <maxime.ripard@bootlin.com>
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190326173810.11979-1-ville.syrjala@linux.intel.com


Acked-by: default avatarMaxime Ripard <maxime.ripard@bootlin.com>
Reviewed-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 9f396ab4

drivers/gpu/drm/sun4i/sun4i_tcon.c

+4 −4
Original line number Diff line number Diff line
@@ -478,7 +478,7 @@ static void sun4i_tcon0_mode_set_rgb(struct sun4i_tcon *tcon, 
				     const struct drm_display_mode *mode)

{

	struct drm_connector *connector = sun4i_tcon_get_connector(encoder);

	struct drm_display_info display_info = connector->display_info;

	const struct drm_display_info *info = &connector->display_info;

	unsigned int bp, hsync, vsync;

	u8 clk_delay;

	u32 val = 0;
@@ -539,7 +539,7 @@ static void sun4i_tcon0_mode_set_rgb(struct sun4i_tcon *tcon, 
	if (mode->flags & DRM_MODE_FLAG_PVSYNC)

		val |= SUN4I_TCON0_IO_POL_VSYNC_POSITIVE;



	if (display_info.bus_flags & DRM_BUS_FLAG_DE_LOW)

	if (info->bus_flags & DRM_BUS_FLAG_DE_LOW)

		val |= SUN4I_TCON0_IO_POL_DE_NEGATIVE;



	/*
@@ -557,10 +557,10 @@ static void sun4i_tcon0_mode_set_rgb(struct sun4i_tcon *tcon, 
	 * Following code is a way to avoid quirks all around TCON

	 * and DOTCLOCK drivers.

	 */

	if (display_info.bus_flags & DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE)

	if (info->bus_flags & DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE)

		clk_set_phase(tcon->dclk, 240);



	if (display_info.bus_flags & DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE)

	if (info->bus_flags & DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE)

		clk_set_phase(tcon->dclk, 0);



	regmap_update_bits(tcon->regs, SUN4I_TCON0_IO_POL_REG,

CRA Git | Maintained and supported by SUSTech CRA and CCSE