Commit 1e41f3bd authored Aug 18, 2020 by Christoph Hellwig Committed by Jens Axboe Aug 21, 2020

nvme: just check the status code type in nvme_is_path_error



Check the SCT sub-field for a path related status instead of enumerating
invididual status code.  As of NVMe 1.4 this adds "Internal Path Error"
and "Controller Pathing Error" to the list, but it also future proofs for
additional status codes added to the category.

Suggested-by: Chao Leng <lengchao@huawei.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 5ddaabe8

drivers/nvme/host/nvme.h

+2 −10

Original line number	Diff line number	Diff line
		@@ -537,16 +537,8 @@ static inline bool nvme_is_ana_error(u16 status)

		static inline bool nvme_is_path_error(u16 status)
		{
		switch (status & 0x7ff) {
		case NVME_SC_HOST_PATH_ERROR:
		case NVME_SC_HOST_ABORTED_CMD:
		case NVME_SC_ANA_TRANSITION:
		case NVME_SC_ANA_INACCESSIBLE:
		case NVME_SC_ANA_PERSISTENT_LOSS:
		return true;
		default:
		return false;
		}
		/* check for a status code type of 'path related status' */
		return (status & 0x700) == 0x300;
		}

		/*

Admin message