platform/x86: intel_pmc_ipc: Use octal permissions in sysfs attributes (1e3872cc) · Commits · 戴 / test

This is the current preferred way so replace the S_IWUSR with the corresponding octal value. While there move the attributes to follow directly their store functions. Signed-off-by:

Mika Westerberg <mika.westerberg@linux.intel.com> Reviewed-by:

Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by:

Andy Shevchenko <andriy.shevchenko@linux.intel.com>

drivers/platform/x86/intel_pmc_ipc.c

+2 −5

Original line number	Diff line number	Diff line
		@@ -502,6 +502,7 @@ static ssize_t intel_pmc_ipc_simple_cmd_store(struct device *dev,
		}
		return (ssize_t)count;
		}
		static DEVICE_ATTR(simplecmd, 0200, NULL, intel_pmc_ipc_simple_cmd_store);

		static ssize_t intel_pmc_ipc_northpeak_store(struct device *dev,
		struct device_attribute *attr,
		@@ -525,11 +526,7 @@ static ssize_t intel_pmc_ipc_northpeak_store(struct device *dev,
		}
		return (ssize_t)count;
		}

		static DEVICE_ATTR(simplecmd, S_IWUSR,
		NULL, intel_pmc_ipc_simple_cmd_store);
		static DEVICE_ATTR(northpeak, S_IWUSR,
		NULL, intel_pmc_ipc_northpeak_store);
		static DEVICE_ATTR(northpeak, 0200, NULL, intel_pmc_ipc_northpeak_store);

		static struct attribute *intel_ipc_attrs[] = {
		&dev_attr_northpeak.attr,

Admin message