Commit 1e358f94 authored Apr 29, 2014 by Bjorn Helgaas

PCI: Fix use of uninitialized MPS value



If "pcie_bus_config == PCIE_BUS_PERFORMANCE", we don't initialize "smpss",
so we pass a pointer to garbage into pcie_bus_configure_set(), where we
compute "mps" based on the garbage.  We then pass the garbage "mps" to
pcie_write_mps(), which ignores it in the PCIE_BUS_PERFORMANCE case.

Coverity isn't smart enough to deduce that we ignore the garbage (it's a
lot to expect from a human, too), so initialize "smpss" to a safe value in
all cases.

Found by Coverity (CID 146454).

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

parent efdd4070

drivers/pci/probe.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1617,7 +1617,7 @@ static int pcie_bus_configure_set(struct pci_dev dev, void data)
		*/
		void pcie_bus_configure_settings(struct pci_bus *bus)
		{
		u8 smpss;
		u8 smpss = 0;

		if (!bus->self)
		return;

Admin message