Commit 1e2d9d44 authored Nov 21, 2012 by Bob Peterson Committed by Steven Whitehouse Nov 21, 2012

GFS2: Set gl_object during inode create

This patch fixes a cluster coherency problem that occurs when one
node creates a file, does several writes, then a different node
tries to write to the same file. When the inode's glock is demoted,
the inode wasn't synced to the media properly because the gl_object
wasn't set. Later, the flush daemon noticed the uncommitted data
and tried to flush it, only to discover the glock was no longer locked
properly in exclusive mode. That caused an assert withdraw.

Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>

parent be4f245d

fs/gfs2/inode.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -702,6 +702,7 @@ static int gfs2_create_inode(struct inode dir, struct dentry dentry,
		if (error)
		goto fail_free_inode;

		ip->i_gl->gl_object = ip;
		error = gfs2_glock_nq_init(ip->i_gl, LM_ST_EXCLUSIVE, GL_SKIP, ghs + 1);
		if (error)
		goto fail_free_inode;

Admin message