USB: serial: mos7720: remove redundant variables iflag, mask and serial (1e2ae1d7) · Commits · 戴 / test

Variables iflag, mask and serial are being assigned but are never used hence are redundant and can be removed. Cleans up clang warnings: warning: variable 'iflag' set but not used [-Wunused-but-set-variable] warning: variable 'mask' set but not used [-Wunused-but-set-variable] warning: variable 'serial' set but not used [-Wunused-but-set-variable] Signed-off-by:

Colin Ian King <colin.king@canonical.com> Signed-off-by:

Johan Hovold <johan@kernel.org>

drivers/usb/serial/mos7720.c

+0 −9

Original line number	Diff line number	Diff line
		@@ -1527,8 +1527,6 @@ static void change_port_settings(struct tty_struct *tty,
		struct usb_serial *serial;
		int baud;
		unsigned cflag;
		unsigned iflag;
		__u8 mask = 0xff;
		__u8 lData;
		__u8 lParity;
		__u8 lStop;
		@@ -1552,23 +1550,19 @@ static void change_port_settings(struct tty_struct *tty,
		lParity = 0x00; /* No parity */

		cflag = tty->termios.c_cflag;
		iflag = tty->termios.c_iflag;

		/* Change the number of bits */
		switch (cflag & CSIZE) {
		case CS5:
		lData = UART_LCR_WLEN5;
		mask = 0x1f;
		break;

		case CS6:
		lData = UART_LCR_WLEN6;
		mask = 0x3f;
		break;

		case CS7:
		lData = UART_LCR_WLEN7;
		mask = 0x7f;
		break;
		default:
		case CS8:
		@@ -1686,11 +1680,8 @@ static void mos7720_set_termios(struct tty_struct *tty,
		struct usb_serial_port port, struct ktermios old_termios)
		{
		int status;
		struct usb_serial *serial;
		struct moschip_port *mos7720_port;

		serial = port->serial;

		mos7720_port = usb_get_serial_port_data(port);

		if (mos7720_port == NULL)

Admin message