irqdomain: Don't set type when mapping an IRQ (1e2a7d78) · Commits · 戴 / test

Some IRQ chips, such as GPIO controllers or secondary level interrupt controllers, may require require additional runtime power management control to ensure they are accessible. For such IRQ chips, it makes sense to enable the IRQ chip when interrupts are requested and disabled them again once all interrupts have been freed. When mapping an IRQ, the IRQ type settings are read and then programmed. The mapping of the IRQ happens before the IRQ is requested and so the programming of the type settings occurs before the IRQ is requested. This is a problem for IRQ chips that require additional power management control because they may not be accessible yet. Therefore, when mapping the IRQ, don't program the type settings, just save them and then program these saved settings when the IRQ is requested (so long as if they are not overridden via the call to request the IRQ). Add a stub function for irq_domain_free_irqs() to avoid any compilation errors when CONFIG_IRQ_DOMAIN_HIERARCHY is not selected. Signed-off-by:

Jon Hunter <jonathanh@nvidia.com> Reviewed-by:

Marc Zyngier <marc.zyngier@arm.com> Signed-off-by:

Marc Zyngier <marc.zyngier@arm.com>

include/linux/irqdomain.h

+3 −0

Original line number	Diff line number	Diff line
		@@ -452,6 +452,9 @@ static inline int irq_domain_alloc_irqs(struct irq_domain *domain,
		return -1;
		}

		static inline void irq_domain_free_irqs(unsigned int virq,
		unsigned int nr_irqs) { }

		static inline bool irq_domain_is_hierarchy(struct irq_domain *domain)
		{
		return false;

kernel/irq/irqdomain.c

+18 −5

Original line number	Diff line number	Diff line
		@@ -567,6 +567,7 @@ static void of_phandle_args_to_fwspec(struct of_phandle_args *irq_data,
		unsigned int irq_create_fwspec_mapping(struct irq_fwspec *fwspec)
		{
		struct irq_domain *domain;
		struct irq_data *irq_data;
		irq_hw_number_t hwirq;
		unsigned int type = IRQ_TYPE_NONE;
		int virq;
		@@ -614,7 +615,11 @@ unsigned int irq_create_fwspec_mapping(struct irq_fwspec *fwspec)
		* it now and return the interrupt number.
		*/
		if (irq_get_trigger_type(virq) == IRQ_TYPE_NONE) {
		irq_set_irq_type(virq, type);
		irq_data = irq_get_irq_data(virq);
		if (!irq_data)
		return 0;

		irqd_set_trigger_type(irq_data, type);
		return virq;
		}

		@@ -634,10 +639,18 @@ unsigned int irq_create_fwspec_mapping(struct irq_fwspec *fwspec)
		return virq;
		}

		/* Set type if specified and different than the current one */
		if (type != IRQ_TYPE_NONE &&
		type != irq_get_trigger_type(virq))
		irq_set_irq_type(virq, type);
		irq_data = irq_get_irq_data(virq);
		if (!irq_data) {
		if (irq_domain_is_hierarchy(domain))
		irq_domain_free_irqs(virq, 1);
		else
		irq_dispose_mapping(virq);
		return 0;
		}

		/* Store trigger type */
		irqd_set_trigger_type(irq_data, type);

		return virq;
		}
		EXPORT_SYMBOL_GPL(irq_create_fwspec_mapping);

Admin message