Commit 1e1a873d authored by Kajol Jain's avatar Kajol Jain Committed by Arnaldo Carvalho de Melo
Browse files

perf metricgroups: Enhance JSON/metric infrastructure to handle "?" 



Patch enhances current metric infrastructure to handle "?" in the metric
expression. The "?" can be use for parameters whose value not known
while creating metric events and which can be replace later at runtime
to the proper value. It also add flexibility to create multiple events
out of single metric event added in JSON file.

Patch adds function 'arch_get_runtimeparam' which is a arch specific
function, returns the count of metric events need to be created.  By
default it return 1.

This infrastructure needed for hv_24x7 socket/chip level events.
"hv_24x7" chip level events needs specific chip-id to which the data is
requested. Function 'arch_get_runtimeparam' implemented in header.c
which extract number of sockets from sysfs file "sockets" under
"/sys/devices/hv_24x7/interface/".

With this patch basically we are trying to create as many metric events
as define by runtime_param.

For that one loop is added in function 'metricgroup__add_metric', which
create multiple events at run time depend on return value of
'arch_get_runtimeparam' and merge that event in 'group_list'.

To achieve that we are actually passing this parameter value as part of
`expr__find_other` function and changing "?" present in metric
expression with this value.

As in our JSON file, there gonna be single metric event, and out of
which we are creating multiple events.

To understand which data count belongs to which parameter value,
we also printing param value in generic_metric function.

For example,

  command:# ./perf stat  -M PowerBUS_Frequency -C 0 -I 1000
    1.000101867  9,356,933  hv_24x7/pm_pb_cyc,chip=0/ #  2.3 GHz  PowerBUS_Frequency_0
    1.000101867  9,366,134  hv_24x7/pm_pb_cyc,chip=1/ #  2.3 GHz  PowerBUS_Frequency_1
    2.000314878  9,365,868  hv_24x7/pm_pb_cyc,chip=0/ #  2.3 GHz  PowerBUS_Frequency_0
    2.000314878  9,366,092  hv_24x7/pm_pb_cyc,chip=1/ #  2.3 GHz  PowerBUS_Frequency_1

So, here _0 and _1 after PowerBUS_Frequency specify parameter value.

Signed-off-by: default avatarKajol Jain <kjain@linux.ibm.com>
Acked-by: default avatarJiri Olsa <jolsa@redhat.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Anju T Sudhakar <anju@linux.vnet.ibm.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jin Yao <yao.jin@linux.intel.com>
Cc: Joe Mario <jmario@redhat.com>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
Cc: Mamatha Inamdar <mamatha4@linux.vnet.ibm.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Michael Petlan <mpetlan@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@ozlabs.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Cc: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linuxppc-dev@lists.ozlabs.org
Link: http://lore.kernel.org/lkml/20200401203340.31402-5-kjain@linux.ibm.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 454a8be0

tools/perf/arch/powerpc/util/header.c

+8 −0
Original line number Diff line number Diff line
@@ -7,6 +7,8 @@ 
#include <string.h>

#include <linux/stringify.h>

#include "header.h"

#include "metricgroup.h"

#include <api/fs/fs.h>



#define mfspr(rn)       ({unsigned long rval; \

			 asm volatile("mfspr %0," __stringify(rn) \
@@ -44,3 +46,9 @@ get_cpuid_str(struct perf_pmu *pmu __maybe_unused) 


	return bufp;

}



int arch_get_runtimeparam(void)

{

	int count;

	return sysfs__read_int("/devices/hv_24x7/interface/sockets", &count) < 0 ? 1 : count;

}

tools/perf/tests/expr.c

+4 −4
Original line number Diff line number Diff line
@@ -10,7 +10,7 @@ static int test(struct expr_parse_ctx *ctx, const char *e, double val2) 
{

	double val;



	if (expr__parse(&val, ctx, e))

	if (expr__parse(&val, ctx, e, 1))

		TEST_ASSERT_VAL("parse test failed", 0);

	TEST_ASSERT_VAL("unexpected value", val == val2);

	return 0;
@@ -44,15 +44,15 @@ int test__expr(struct test *t __maybe_unused, int subtest __maybe_unused) 
		return ret;



	p = "FOO/0";

	ret = expr__parse(&val, &ctx, p);

	ret = expr__parse(&val, &ctx, p, 1);

	TEST_ASSERT_VAL("division by zero", ret == -1);



	p = "BAR/";

	ret = expr__parse(&val, &ctx, p);

	ret = expr__parse(&val, &ctx, p, 1);

	TEST_ASSERT_VAL("missing operand", ret == -1);



	TEST_ASSERT_VAL("find other",

			expr__find_other("FOO + BAR + BAZ + BOZO", "FOO", &other, &num_other) == 0);

			expr__find_other("FOO + BAR + BAZ + BOZO", "FOO", &other, &num_other, 1) == 0);

	TEST_ASSERT_VAL("find other", num_other == 3);

	TEST_ASSERT_VAL("find other", !strcmp(other[0], "BAR"));

	TEST_ASSERT_VAL("find other", !strcmp(other[1], "BAZ"));

tools/perf/util/expr.c

+6 −5
Original line number Diff line number Diff line
@@ -27,10 +27,11 @@ void expr__ctx_init(struct expr_parse_ctx *ctx) 


static int

__expr__parse(double *val, struct expr_parse_ctx *ctx, const char *expr,

	      int start)

	      int start, int runtime)

{

	struct expr_scanner_ctx scanner_ctx = {

		.start_token = start,

		.runtime = runtime,

	};

	YY_BUFFER_STATE buffer;

	void *scanner;
@@ -54,9 +55,9 @@ __expr__parse(double *val, struct expr_parse_ctx *ctx, const char *expr, 
	return ret;

}



int expr__parse(double *final_val, struct expr_parse_ctx *ctx, const char *expr)

int expr__parse(double *final_val, struct expr_parse_ctx *ctx, const char *expr, int runtime)

{

	return __expr__parse(final_val, ctx, expr, EXPR_PARSE) ? -1 : 0;

	return __expr__parse(final_val, ctx, expr, EXPR_PARSE, runtime) ? -1 : 0;

}



static bool
@@ -74,13 +75,13 @@ already_seen(const char *val, const char *one, const char **other, 
}



int expr__find_other(const char *expr, const char *one, const char ***other,

		     int *num_other)

		     int *num_other, int runtime)

{

	int err, i = 0, j = 0;

	struct expr_parse_ctx ctx;



	expr__ctx_init(&ctx);

	err = __expr__parse(NULL, &ctx, expr, EXPR_OTHER);

	err = __expr__parse(NULL, &ctx, expr, EXPR_OTHER, runtime);

	if (err)

		return -1;

tools/perf/util/expr.h

+3 −2
Original line number Diff line number Diff line
@@ -17,12 +17,13 @@ struct expr_parse_ctx { 


struct expr_scanner_ctx {

	int start_token;

	int runtime;

};



void expr__ctx_init(struct expr_parse_ctx *ctx);

void expr__add_id(struct expr_parse_ctx *ctx, const char *id, double val);

int expr__parse(double *final_val, struct expr_parse_ctx *ctx, const char *expr);

int expr__parse(double *final_val, struct expr_parse_ctx *ctx, const char *expr, int runtime);

int expr__find_other(const char *expr, const char *one, const char ***other,

		int *num_other);

		int *num_other, int runtime);



#endif

tools/perf/util/expr.l

+20 −7
Original line number Diff line number Diff line
@@ -35,7 +35,7 @@ static int value(yyscan_t scanner, int base) 
 * Allow @ instead of / to be able to specify pmu/event/ without

 * conflicts with normal division.

 */

static char *normalize(char *str)

static char *normalize(char *str, int runtime)

{

	char *ret = str;

	char *dst = str;
@@ -45,6 +45,19 @@ static char *normalize(char *str) 
			*dst++ = '/';

		else if (*str == '\\')

			*dst++ = *++str;

		 else if (*str == '?') {

			char *paramval;

			int i = 0;

			int size = asprintf(&paramval, "%d", runtime);



			if (size < 0)

				*dst++ = '0';

			else {

				while (i < size)

					*dst++ = paramval[i++];

				free(paramval);

			}

		}

		else

			*dst++ = *str;

		str++;
@@ -54,16 +67,16 @@ static char *normalize(char *str) 
	return ret;

}



static int str(yyscan_t scanner, int token)

static int str(yyscan_t scanner, int token, int runtime)

{

	YYSTYPE *yylval = expr_get_lval(scanner);

	char *text = expr_get_text(scanner);



	yylval->str = normalize(strdup(text));

	yylval->str = normalize(strdup(text), runtime);

	if (!yylval->str)

		return EXPR_ERROR;



	yylval->str = normalize(yylval->str);

	yylval->str = normalize(yylval->str, runtime);

	return token;

}

%}
@@ -72,8 +85,8 @@ number [0-9]+ 


sch		[-,=]

spec		\\{sch}

sym		[0-9a-zA-Z_\.:@]+

symbol		{spec}*{sym}*{spec}*{sym}*

sym		[0-9a-zA-Z_\.:@?]+

symbol		{spec}*{sym}*{spec}*{sym}*{spec}*{sym}



%%

	struct expr_scanner_ctx *sctx = expr_get_extra(yyscanner);
@@ -93,7 +106,7 @@ if { return IF; } 
else		{ return ELSE; }

#smt_on		{ return SMT_ON; }

{number}	{ return value(yyscanner, 10); }

{symbol}	{ return str(yyscanner, ID); }

{symbol}	{ return str(yyscanner, ID, sctx->runtime); }

"|"		{ return '|'; }

"^"		{ return '^'; }

"&"		{ return '&'; }

CRA Git | Maintained and supported by SUSTech CRA and CCSE