Commit 1e0f8f68 authored Apr 14, 2017 by Takashi Sakamoto Committed by Takashi Iwai Apr 14, 2017

ALSA: usb-line6: constify snd_kcontrol_new strucutre array



In kernel APIs of ALSA control interface, drivers can create a control
element set by a call of snd_ctl_new1() with a template. This template
is known to have const qualifier in general cases.

This commit adds the qualifier to template array, for safer program and
runtime. Application of this change moves the symbol from .data section
to .rodata section.

Cc: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent a87a4d23

sound/usb/line6/pcm.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -430,7 +430,7 @@ static int snd_line6_control_playback_put(struct snd_kcontrol *kcontrol,
		}

		/* control definition */
		static struct snd_kcontrol_new line6_controls[] = {
		static const struct snd_kcontrol_new line6_controls[] = {
		{
		.iface = SNDRV_CTL_ELEM_IFACE_MIXER,
		.name = "PCM Playback Volume",

Admin message