UBI: Don't read back all data in ubi_eba_copy_leb() (1e0a74f1) · Commits · 戴 / test

Drop this paranoia check from the old days. If our MTD driver or the flash is so bad that we even cannot trust it to write data we have bigger problems. If one really does not trust the flash and wants write-verify she can enable UBI io checks using debugfs. Signed-off-by:

Richard Weinberger <richard@nod.at>

drivers/mtd/ubi/eba.c

+0 −26

Original line number	Diff line number	Diff line
		@@ -1202,32 +1202,6 @@ int ubi_eba_copy_leb(struct ubi_device *ubi, int from, int to,
		}

		cond_resched();

		/*
		* We've written the data and are going to read it back to make
		* sure it was written correctly.
		*/
		memset(ubi->peb_buf, 0xFF, aldata_size);
		err = ubi_io_read_data(ubi, ubi->peb_buf, to, 0, aldata_size);
		if (err) {
		if (err != UBI_IO_BITFLIPS) {
		ubi_warn(ubi, "error %d while reading data back from PEB %d",
		err, to);
		if (is_error_sane(err))
		err = MOVE_TARGET_RD_ERR;
		} else
		err = MOVE_TARGET_BITFLIPS;
		goto out_unlock_buf;
		}

		cond_resched();

		if (crc != crc32(UBI_CRC32_INIT, ubi->peb_buf, data_size)) {
		ubi_warn(ubi, "read data back from PEB %d and it is different",
		to);
		err = -EINVAL;
		goto out_unlock_buf;
		}
		}

		ubi_assert(vol->eba_tbl[lnum] == from);

Admin message