[PATCH] x86_64: Fix up outdated pfn_to_page comment (1dff7f3d) · Commits · 戴 / test

pfn_to_page really requires pfn_valid to be true now, no question. Some people stumbled over it, but it was misleading and wrong. Signed-off-by:

include/asm-x86_64/mmzone.h

+1 −3

Original line number	Diff line number	Diff line
		@@ -41,9 +41,7 @@ static inline __attribute__((pure)) int phys_to_nid(unsigned long addr)
		#define pfn_to_nid(pfn) phys_to_nid((unsigned long)(pfn) << PAGE_SHIFT)
		#define kvaddr_to_nid(kaddr) phys_to_nid(__pa(kaddr))

		/* AK: this currently doesn't deal with invalid addresses. We'll see
		if the 2.5 kernel doesn't pass them
		(2.4 used to). */
		/* Requires pfn_valid(pfn) to be true */
		#define pfn_to_page(pfn) ({ \
		int nid = phys_to_nid(((unsigned long)(pfn)) << PAGE_SHIFT); \
		((pfn) - node_start_pfn(nid)) + NODE_DATA(nid)->node_mem_map; \