Commit 1df627b4 authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen
Browse files

scsi: qla2xxx: Do not corrupt vha->plogi_ack_list 



Delete the PLOGIN ACK data structure from the vha->plogi_ack_list before
freeing that data structure to avoid that that list gets corrupted.

Cc: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Tested-by: default avatarHimanshu Madhani <hmadhani@marvell.com>
Reviewed-by: default avatarHimanshu Madhani <hmadhani@marvell.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent b3e9772d

drivers/scsi/qla2xxx/qla_os.c

+6 −2
Original line number Diff line number Diff line
@@ -5083,8 +5083,10 @@ void qla24xx_create_new_sess(struct scsi_qla_host *vha, struct qla_work_evt *e) 
				   "%s %8phC mem alloc fail.\n",

				   __func__, e->u.new_sess.port_name);



			if (pla)

			if (pla) {

				list_del(&pla->list);

				kmem_cache_free(qla_tgt_plogi_cachep, pla);

			}

			return;

		}
@@ -5195,10 +5197,12 @@ void qla24xx_create_new_sess(struct scsi_qla_host *vha, struct qla_work_evt *e) 


	if (free_fcport) {

		qla2x00_free_fcport(fcport);

		if (pla)

		if (pla) {

			list_del(&pla->list);

			kmem_cache_free(qla_tgt_plogi_cachep, pla);

		}

	}

}



static void qla_sp_retry(struct scsi_qla_host *vha, struct qla_work_evt *e)

{

drivers/scsi/qla2xxx/qla_target.c

+3 −1
Original line number Diff line number Diff line
@@ -4796,8 +4796,10 @@ static int qlt_handle_login(struct scsi_qla_host *vha, 
			    __func__, sess->port_name, sec);

		}



		if (!conflict_sess)

		if (!conflict_sess) {

			list_del(&pla->list);

			kmem_cache_free(qla_tgt_plogi_cachep, pla);

		}



		qlt_send_term_imm_notif(vha, iocb, 1);

		goto out;

CRA Git | Maintained and supported by SUSTech CRA and CCSE