Commit 1dd594b2 authored Mar 20, 2006 by Neil Brown Committed by Trond Myklebust Mar 20, 2006

NFS: Fix buglet in fs/nfs/write.c



I've been reading through fs/nfs/write.c trying to track down a bug
that seems to be related to pages loosing a refcount and getting
freed too early (you interested in detail??) and I spotted a little
bug which the following patch should fix.

Signed-off-by: Neil Brown <neilb@suse.de>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

parent cd52ed35

fs/nfs/write.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -653,8 +653,11 @@ static struct nfs_page * nfs_update_request(struct nfs_open_context* ctx,
		spin_unlock(&nfsi->req_lock);
		error = nfs_wait_on_request(req);
		nfs_release_request(req);
		if (error < 0)
		if (error < 0) {
		if (new)
		nfs_release_request(new);
		return ERR_PTR(error);
		}
		continue;
		}
		spin_unlock(&nfsi->req_lock);

Admin message