Commit 1dbb9fb4 authored Aug 16, 2019 by Andy Shevchenko Committed by Jacek Anaszewski Aug 26, 2019

leds: Allow to call led_classdev_unregister() unconditionally



If in the certain driver the LED is optional, and it's a majority of them,
the call of led_classdev_unregister() still requires some additional
checks.

The usual pattern on unregistering is to check for NULL, but we also check
for IS_ERR() in case device_create_with_groups() fails.

The change will reduce a burden in a lot of drivers to repeatedly check
for above conditions.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>

parent 517ea49a

drivers/leds/led-class.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -287,6 +287,7 @@ int led_classdev_register_ext(struct device *parent,
		ret = led_add_brightness_hw_changed(led_cdev);
		if (ret) {
		device_unregister(led_cdev->dev);
		led_cdev->dev = NULL;
		mutex_unlock(&led_cdev->led_access);
		return ret;
		}
		@@ -332,6 +333,9 @@ EXPORT_SYMBOL_GPL(led_classdev_register_ext);
		*/
		void led_classdev_unregister(struct led_classdev *led_cdev)
		{
		if (IS_ERR_OR_NULL(led_cdev->dev))
		return;

		#ifdef CONFIG_LEDS_TRIGGERS
		down_write(&led_cdev->trigger_lock);
		if (led_cdev->trigger)

Admin message