Commit 1daaae8f authored Mar 21, 2012 by Jeff Layton Committed by Steve French Mar 21, 2012

cifs: fix issue mounting of DFS ROOT when redirecting from one domain controller to the next



This patch fixes an issue when cifs_mount receives a
STATUS_BAD_NETWORK_NAME error during cifs_get_tcon but is able to
continue after an DFS ROOT referral. In this case, the return code
variable is not reset prior to trying to mount from the system referred
to. Thus, is_path_accessible is not executed and the final DFS referral
is not performed causing a mount error.

Use case: In DNS, example.com  resolves to the secondary AD server
ad2.example.com Our primary domain controller is ad1.example.com and has
a DFS redirection set up from \\ad1\share\Users to \\files\share\Users.
Mounting \\example.com\share\Users fails.

Regression introduced by commit 724d9f1c.

Cc: stable@vger.kernel.org
Reviewed-by: Pavel Shilovsky <piastry@etersoft.ru>
Signed-off-by: Thomas Hadig <thomas@intapp.com>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>

parent 10b9b98e

fs/cifs/connect.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -3368,7 +3368,7 @@ cifs_ra_pages(struct cifs_sb_info *cifs_sb)
		int
		cifs_mount(struct cifs_sb_info cifs_sb, struct smb_vol volume_info)
		{
		int rc = 0;
		int rc;
		int xid;
		struct cifs_ses *pSesInfo;
		struct cifs_tcon *tcon;
		@@ -3395,6 +3395,7 @@ try_mount_again:
		FreeXid(xid);
		}
		#endif
		rc = 0;
		tcon = NULL;
		pSesInfo = NULL;
		srvTcp = NULL;

Admin message