Commit 1d8ef0c0 authored Feb 01, 2018 by Edwin Peer Committed by David S. Miller Feb 02, 2018

nfp: fix TLV offset calculation



The data pointer in the config space TLV parser already includes
NFP_NET_CFG_TLV_BASE, it should not be added again. Incorrect
offset values were only used in printed user output, rendering
the bug merely cosmetic.

Fixes: 73a0329b ("nfp: add TLV capabilities to the BAR")
Signed-off-by: Edwin Peer <edwin.peer@netronome.com>
Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 743ffffe

drivers/net/ethernet/netronome/nfp/nfp_net_ctrl.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -65,7 +65,7 @@ int nfp_net_tlv_caps_parse(struct device dev, u8 __iomem ctrl_mem,
		u32 hdr = readl(data);

		length = FIELD_GET(NFP_NET_CFG_TLV_HEADER_LENGTH, hdr);
		offset = data - ctrl_mem + NFP_NET_CFG_TLV_BASE;
		offset = data - ctrl_mem;

		/* Advance past the header */
		data += 4;

Admin message