USB: isp116x: remove dependency on CONFIG_USB_DEBUG (1d896cea) · Commits · 戴 / test

Move all debugging messages in the driver to use the dynamic debug subsystem, and not rely on CONFIG_USB_DEBUG to turn them on or off. This lets debugging be enabled without having to rebuild the driver, an important thing for users that can not do it. It also removes the pointless IRQ_TEST() macro, as that was totally useless and obviously never used. Cc: Olav Kongas <ok@artecdesign.ee> Acked-by:

Felipe Balbi <balbi@ti.com> Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/usb/host/isp116x.h

+1 −12

Original line number	Diff line number	Diff line
		@@ -325,11 +325,7 @@ struct isp116x_ep {

		/-------------------------------------------------------------------------/

		#ifdef DEBUG
		#define DBG(stuff...) printk(KERN_DEBUG "116x: " stuff)
		#else
		#define DBG(stuff...) do{}while(0)
		#endif
		#define DBG(stuff...) pr_debug("116x: " stuff)

		#ifdef VERBOSE
		# define VDBG DBG
		@@ -358,15 +354,8 @@ struct isp116x_ep {
		#define isp116x_check_platform_delay(h) 0
		#endif

		#if defined(DEBUG)
		#define IRQ_TEST() BUG_ON(!irqs_disabled())
		#else
		#define IRQ_TEST() do{}while(0)
		#endif

		static inline void isp116x_write_addr(struct isp116x *isp116x, unsigned reg)
		{
		IRQ_TEST();
		writew(reg & 0xff, isp116x->addr_reg);
		isp116x_delay(isp116x, 300);
		}

Admin message