Commit 1d84487e authored Oct 19, 2017 by Quentin Monnet Committed by David S. Miller Oct 22, 2017

tools: bpftool: use err() instead of info() if there are too many insns



Make error messages and return codes more consistent. Specifically,
replace the use of info() macro with err() when too many eBPF
instructions are received to be dumped, given that bpftool returns with
a non-null exit value in that case.

Signed-off-by: Quentin Monnet <quentin.monnet@netronome.com>
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 1739c26d

tools/bpf/bpftool/prog.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -416,7 +416,7 @@ static int do_dump(int argc, char **argv)
	}		}

	if (*member_len > buf_size) {		if (*member_len > buf_size) {
	info("too many instructions returned\n");		err("too many instructions returned\n");
	goto err_free;		goto err_free;
	}		}

Admin message