Commit 1d839317 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Linus Torvalds
Browse files

avr32: use generic ptrace_resume code 



Use the generic ptrace_resume code for PTRACE_SYSCALL, PTRACE_CONT,
PTRACE_KILL and PTRACE_SINGLESTEP.  This implies defining
arch_has_single_step in <asm/ptrace.h> and implementing the
user_enable_single_step and user_disable_single_step functions, which also
causes the breakpoint information to be cleared on fork, which could be
considered a bug fix.

Also the TIF_SYSCALL_TRACE thread flag is now cleared on PTRACE_KILL which
it previously wasn't which is consistent with all architectures using the
modern ptrace code.

Currently avr32 doesn't implement any code to disable single stepping when
one of the non-syscall requests is called which seems wrong, but I've left
it as-is for now.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Roland McGrath <roland@redhat.com>
Acked-by: default avatarHaavard Skinnemoen <hskinnemoen@atmel.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 440e6ca7

arch/avr32/include/asm/ptrace.h

+2 −0
Original line number Diff line number Diff line
@@ -124,6 +124,8 @@ struct pt_regs { 


#include <asm/ocd.h>



#define arch_has_single_step()		(1)



#define arch_ptrace_attach(child)       ocd_enable(child)



#define user_mode(regs)                 (((regs)->sr & MODE_MASK) == MODE_USER)

arch/avr32/kernel/ptrace.c

+7 −46
Original line number Diff line number Diff line
@@ -28,9 +28,9 @@ static struct pt_regs *get_user_regs(struct task_struct *tsk) 
				  THREAD_SIZE - sizeof(struct pt_regs));

}



static void ptrace_single_step(struct task_struct *tsk)

static void user_enable_single_step(struct task_struct *tsk)

{

	pr_debug("ptrace_single_step: pid=%u, PC=0x%08lx, SR=0x%08lx\n",

	pr_debug("user_enable_single_step: pid=%u, PC=0x%08lx, SR=0x%08lx\n",

		 tsk->pid, task_pt_regs(tsk)->pc, task_pt_regs(tsk)->sr);



	/*
@@ -49,6 +49,11 @@ static void ptrace_single_step(struct task_struct *tsk) 
	set_tsk_thread_flag(tsk, TIF_SINGLE_STEP);

}



void user_disable_single_step(struct task_struct *child)

{

	/* XXX(hch): a no-op here seems wrong.. */

}



/*

 * Called by kernel/ptrace.c when detaching

 *
@@ -167,50 +172,6 @@ long arch_ptrace(struct task_struct *child, long request, long addr, long data) 
		ret = ptrace_write_user(child, addr, data);

		break;



	/* continue and stop at next (return from) syscall */

	case PTRACE_SYSCALL:

	/* restart after signal */

	case PTRACE_CONT:

		ret = -EIO;

		if (!valid_signal(data))

			break;

		if (request == PTRACE_SYSCALL)

			set_tsk_thread_flag(child, TIF_SYSCALL_TRACE);

		else

			clear_tsk_thread_flag(child, TIF_SYSCALL_TRACE);

		child->exit_code = data;

		/* XXX: Are we sure no breakpoints are active here? */

		wake_up_process(child);

		ret = 0;

		break;



	/*

	 * Make the child exit. Best I can do is send it a

	 * SIGKILL. Perhaps it should be put in the status that it

	 * wants to exit.

	 */

	case PTRACE_KILL:

		ret = 0;

		if (child->exit_state == EXIT_ZOMBIE)

			break;

		child->exit_code = SIGKILL;

		wake_up_process(child);

		break;



	/*

	 * execute single instruction.

	 */

	case PTRACE_SINGLESTEP:

		ret = -EIO;

		if (!valid_signal(data))

			break;

		clear_tsk_thread_flag(child, TIF_SYSCALL_TRACE);

		ptrace_single_step(child);

		child->exit_code = data;

		wake_up_process(child);

		ret = 0;

		break;



	case PTRACE_GETREGS:

		ret = ptrace_getregs(child, (void __user *)data);

		break;

CRA Git | Maintained and supported by SUSTech CRA and CCSE