Commit 1d7b33f7 authored Feb 12, 2009 by Inaky Perez-Gonzalez Committed by David S. Miller Feb 12, 2009

wimax: fix oops in wimax_dev_get_by_genl_info() when looking up non-wimax iface



When a non-wimax interface is looked up by the stack, a bad pointer is
returned when the looked-up interface is not found in the list (of
registered WiMAX interfaces). This causes an oops in the caller when
trying to use the pointer.

Fix by properly setting the pointer to NULL if we don't exit from the
list_for_each() with a found entry.

Signed-off-by: Inaky Perez-Gonzalez <inaky@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent df0bca04

net/wimax/id-table.c

+5 −4

Original line number	Diff line number	Diff line
		@@ -94,12 +94,13 @@ struct wimax_dev *wimax_dev_get_by_genl_info(
		list_for_each_entry(wimax_dev, &wimax_id_table, id_table_node) {
		if (wimax_dev->net_dev->ifindex == ifindex) {
		dev_hold(wimax_dev->net_dev);
		break;
		goto found;
		}
		}
		if (wimax_dev == NULL)
		wimax_dev = NULL;
		d_printf(1, NULL, "wimax: no devices found with ifindex %d\n",
		ifindex);
		found:
		spin_unlock(&wimax_id_table_lock);
		d_fnend(3, NULL, "(info %p ifindex %d) = %p\n",
		info, ifindex, wimax_dev);

Admin message