Commit 1d7a7128 authored May 02, 2020 by Qiushi Wu Committed by Sebastian Reichel May 03, 2020

power: supply: core: fix memory leak in HWMON error path



In function power_supply_add_hwmon_sysfs(), psyhw->props is
allocated by bitmap_zalloc(). But this pointer is not deallocated
when devm_add_action fail,  which lead to a memory leak bug. To fix
this, we replace devm_add_action with devm_add_action_or_reset.

Cc: stable@kernel.org
Fixes: e67d4dfc ("power: supply: Add HWMON compatibility layer")
Signed-off-by: Qiushi Wu <wu000273@umn.edu>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

parent 21d4cdf8

drivers/power/supply/power_supply_hwmon.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -358,7 +358,7 @@ int power_supply_add_hwmon_sysfs(struct power_supply *psy)
		goto error;
		}

		ret = devm_add_action(dev, power_supply_hwmon_bitmap_free,
		ret = devm_add_action_or_reset(dev, power_supply_hwmon_bitmap_free,
		psyhw->props);
		if (ret)
		goto error;

Admin message