Commit 1d4a09da authored by Phong Tran's avatar Phong Tran Committed by David S. Miller
Browse files

net: hso: Fix -Wcast-function-type 

correct usage prototype of callback in tasklet_init().
Report by https://github.com/KSPP/linux/issues/20



Signed-off-by: default avatarPhong Tran <tranmanphong@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 82f31ebf

drivers/net/usb/hso.c

+3 −2
Original line number Diff line number Diff line
@@ -1214,8 +1214,9 @@ static void hso_std_serial_read_bulk_callback(struct urb *urb) 
 * This needs to be a tasklet otherwise we will

 * end up recursively calling this function.

 */

static void hso_unthrottle_tasklet(struct hso_serial *serial)

static void hso_unthrottle_tasklet(unsigned long data)

{

	struct hso_serial *serial = (struct hso_serial *)data;

	unsigned long flags;



	spin_lock_irqsave(&serial->serial_lock, flags);
@@ -1265,7 +1266,7 @@ static int hso_serial_open(struct tty_struct *tty, struct file *filp) 
		/* Force default termio settings */

		_hso_serial_set_termios(tty, NULL);

		tasklet_init(&serial->unthrottle_tasklet,

			     (void (*)(unsigned long))hso_unthrottle_tasklet,

			     hso_unthrottle_tasklet,

			     (unsigned long)serial);

		result = hso_start_serial_device(serial->parent, GFP_KERNEL);

		if (result) {

CRA Git | Maintained and supported by SUSTech CRA and CCSE