Commit 1d3c6f86 authored Mar 26, 2020 by John Stultz Committed by Bjorn Andersson Apr 14, 2020

soc: qcom: rpmh: Allow RPMH driver to be loaded as a module



This patch allow the rpmh driver to be loaded as a permenent
module. Meaning it can be loaded from a module, but then cannot
be unloaded.

Ideally, it would include a remove hook and related logic, but
the rpmh driver is fairly core to the system, so once its loaded
with almost anythign else to get the system to go, the dependencies
are not likely to ever also be removed.

So making it a permenent module at least improves things slightly
over requiring it to be a built in driver.

Acked-by: Saravana Kannan <saravanak@google.com>
Cc: Todd Kjos <tkjos@google.com>
Cc: Saravana Kannan <saravanak@google.com>
Cc: Andy Gross <agross@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Rajendra Nayak <rnayak@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org
Tested-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: John Stultz <john.stultz@linaro.org>
Link: https://lore.kernel.org/r/20200326224459.105170-3-john.stultz@linaro.org


Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

parent 032c692a

drivers/soc/qcom/Kconfig

+1 −1

Original line number	Diff line number	Diff line
		@@ -107,7 +107,7 @@ config QCOM_RMTFS_MEM
		Say y here if you intend to boot the modem remoteproc.

		config QCOM_RPMH
		bool "Qualcomm RPM-Hardened (RPMH) Communication"
		tristate "Qualcomm RPM-Hardened (RPMH) Communication"
		depends on ARCH_QCOM && ARM64 \|\| COMPILE_TEST
		help
		Support for communication with the hardened-RPM blocks in

drivers/soc/qcom/rpmh-rsc.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -12,6 +12,7 @@
		#include <linux/io.h>
		#include <linux/kernel.h>
		#include <linux/list.h>
		#include <linux/module.h>
		#include <linux/of.h>
		#include <linux/of_irq.h>
		#include <linux/of_platform.h>
		@@ -985,6 +986,7 @@ static const struct of_device_id rpmh_drv_match[] = {
		{ .compatible = "qcom,rpmh-rsc", },
		{ }
		};
		MODULE_DEVICE_TABLE(of, rpmh_drv_match);

		static struct platform_driver rpmh_driver = {
		.probe = rpmh_rsc_probe,
		@@ -999,3 +1001,6 @@ static int __init rpmh_driver_init(void)
		return platform_driver_register(&rpmh_driver);
		}
		arch_initcall(rpmh_driver_init);

		MODULE_DESCRIPTION("Qualcomm Technologies, Inc. RPMh Driver");
		MODULE_LICENSE("GPL v2");

Admin message