Unverified Commit 1d38b4e9 authored Dec 26, 2018 by Gustavo A. R. Silva Committed by Mark Brown Jan 03, 2019

ASoC: xlnx: fix error handling in xlnx_formatter_pcm_probe



Currently, if platform_get_irq_byname() fails, the returned error
turns into a huge value, once it is being store into a variable
of type unsigned int, hence never actually reporting any error
and causing unexpected behavior when using the values stored
in aud_drv_data->s2mm_irq and aud_drv_data->mm2s_irq.

Fix this by changing the type of variables s2mm_irq and mm2s_irq in
structure xlnx_pcm_drv_data from unsigned int to int.

Addresses-Coverity-ID: 1476096 ("Unsigned compared against 0")
Fixes: 796175a94a7f ("ASoC: xlnx: add pcm formatter platform driver")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent f5758544

sound/soc/xilinx/xlnx_formatter_pcm.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -76,8 +76,8 @@ struct xlnx_pcm_drv_data {
		void __iomem *mmio;
		bool s2mm_presence;
		bool mm2s_presence;
		unsigned int s2mm_irq;
		unsigned int mm2s_irq;
		int s2mm_irq;
		int mm2s_irq;
		struct snd_pcm_substream *play_stream;
		struct snd_pcm_substream *capture_stream;
		struct clk *axi_clk;

Admin message