drm/vmwgfx: Use correct vmw_legacy_display_unit pointer (1d2c0c56) · Commits · 戴 / test

The "entry" pointer is an offset from the list head and it doesn't point to a valid vmw_legacy_display_unit struct. Presumably the intent was to point to the last entry. Also the "i++" wasn't used so I have removed that as well. Fixes: ("drm/vmwgfx: Support older hardware.") Signed-off-by:

Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by:

Roland Scheidegger <sroland@vmware.com> Signed-off-by:

Roland Scheidegger <sroland@vmware.com>

drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -81,7 +81,7 @@ static int vmw_ldu_commit_list(struct vmw_private *dev_priv)
		struct vmw_legacy_display_unit *entry;
		struct drm_framebuffer *fb = NULL;
		struct drm_crtc *crtc = NULL;
		int i = 0;
		int i;

		/* If there is no display topology the host just assumes
		* that the guest will set the same layout as the host.
		@@ -92,12 +92,11 @@ static int vmw_ldu_commit_list(struct vmw_private *dev_priv)
		crtc = &entry->base.crtc;
		w = max(w, crtc->x + crtc->mode.hdisplay);
		h = max(h, crtc->y + crtc->mode.vdisplay);
		i++;
		}

		if (crtc == NULL)
		return 0;
		fb = entry->base.crtc.primary->state->fb;
		fb = crtc->primary->state->fb;

		return vmw_kms_write_svga(dev_priv, w, h, fb->pitches[0],
		fb->format->cpp[0] * 8,

Admin message