Commit 1d1d14da authored by Peter Hurley's avatar Peter Hurley Committed by Greg Kroah-Hartman
Browse files

pty: Fix buffer flush deadlock 



The pty driver does not clear its write buffer when commanded.
This is to avoid an apparent deadlock between parallel flushes from
both pty ends; specifically when handling either BRK or INTR input.
However, parallel flushes from this source is not possible since
the pty master can never be set to BRKINT or ISIG. Parallel flushes
from other sources are possible but these do not threaten deadlocks.

Annotate the tty buffer mutex for lockdep to represent the nested
tty_buffer locking which occurs when the pty slave is processing input
(its buffer mutex held) and receives INTR or BRK and acquires the
linked tty buffer mutex via tty_buffer_flush().

Signed-off-by: default avatarPeter Hurley <peter@hurleysoftware.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3abf87cd

drivers/tty/pty.c

+9 −1
Original line number Diff line number Diff line
@@ -212,10 +212,16 @@ static int pty_signal(struct tty_struct *tty, int sig) 
static void pty_flush_buffer(struct tty_struct *tty)

{

	struct tty_struct *to = tty->link;

	struct tty_ldisc *ld;



	if (!to)

		return;

	/* tty_buffer_flush(to); FIXME */



	ld = tty_ldisc_ref(to);

	tty_buffer_flush(to, ld);

	if (ld)

		tty_ldisc_deref(ld);



	if (to->packet) {

		spin_lock_irq(&tty->ctrl_lock);

		tty->ctrl_status |= TIOCPKT_FLUSHWRITE;
@@ -425,6 +431,8 @@ static int pty_common_install(struct tty_driver *driver, struct tty_struct *tty, 
	tty->port = ports[1];

	o_tty->port->itty = o_tty;



	tty_buffer_set_lock_subclass(o_tty->port);



	tty_driver_kref_get(driver);

	tty->count++;

	o_tty->count++;

drivers/tty/tty_buffer.c

+6 −0
Original line number Diff line number Diff line
@@ -557,3 +557,9 @@ int tty_buffer_set_limit(struct tty_port *port, int limit) 
	return 0;

}

EXPORT_SYMBOL_GPL(tty_buffer_set_limit);



/* slave ptys can claim nested buffer lock when handling BRK and INTR */

void tty_buffer_set_lock_subclass(struct tty_port *port)

{

	lockdep_set_subclass(&port->buf.lock, TTY_LOCK_SLAVE);

}

include/linux/tty.h

+4 −0
Original line number Diff line number Diff line
@@ -25,6 +25,9 @@ 
 *

 * legacy_mutex - Nested tty locks are necessary for releasing pty pairs.

 *		  The stable lock order is master pty first, then slave pty.

 * tty_buffer lock - slave ptys can claim nested buffer lock when handling

 *		     signal chars. The stable lock order is slave pty, then

 *		     master.

 */



enum {
@@ -460,6 +463,7 @@ extern void tty_flush_to_ldisc(struct tty_struct *tty); 
extern void tty_buffer_free_all(struct tty_port *port);

extern void tty_buffer_flush(struct tty_struct *tty, struct tty_ldisc *ld);

extern void tty_buffer_init(struct tty_port *port);

extern void tty_buffer_set_lock_subclass(struct tty_port *port);

extern speed_t tty_termios_baud_rate(struct ktermios *termios);

extern speed_t tty_termios_input_baud_rate(struct ktermios *termios);

extern void tty_termios_encode_baud_rate(struct ktermios *termios,

CRA Git | Maintained and supported by SUSTech CRA and CCSE