Unverified Commit 1d159edf authored Oct 12, 2020 by Cezary Rojewski Committed by Mark Brown Oct 14, 2020

ASoC: Intel: catpt: Wake up device before configuring SSP port

catpt_dai_pcm_new() invoked during new PCM runtime creation configures
SSP by sending IPC to DSP firmware. For that to succeed device needs to
be up and running. While components default probing behavior -
snd_soc_catpt causing machine board module to load just after it - needs
no changes, machine board's module may be unloaded and re-loaded at a
different time e.g.: when catpt is already asleep.

Wake device explicitly in catpt_dai_pcm_new() to ensure communication is
established before sending any IPCs, enabling those advanced scenarios
in the process.

Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
Link: https://lore.kernel.org/r/20201012103221.30759-1-cezary.rojewski@intel.com

Signed-off-by: Mark Brown <broonie@kernel.org>

parent 1849a387

sound/soc/intel/catpt/pcm.c

+10 −0

Original line number	Diff line number	Diff line
		@@ -667,7 +667,17 @@ static int catpt_dai_pcm_new(struct snd_soc_pcm_runtime *rtm,
		break;
		}

		/* see if this is a new configuration */
		if (!memcmp(&cdev->devfmt[devfmt.iface], &devfmt, sizeof(devfmt)))
		return 0;

		pm_runtime_get_sync(cdev->dev);

		ret = catpt_ipc_set_device_format(cdev, &devfmt);

		pm_runtime_mark_last_busy(cdev->dev);
		pm_runtime_put_autosuspend(cdev->dev);

		if (ret)
		return CATPT_IPC_ERROR(ret);

Admin message