nvdimm: Clarify comment in sizeof_namespace_index (1cfeb66e) · Commits · 戴 / test

When working on the label code I found it rather confusing to see several spots that reference a minimum label size of 256 while working with labels that are 128 bytes in size. This patch is meant to provide a clarification on one of the comments that was at the heart of the issue. Specifically for version 1.2 and later of the namespace specification the minimum label size is 256, prior to that the minimum label size was 128. So we should state that as such to avoid confusion. Reviewed-by:

Toshi Kani <toshi.kani@hpe.com> Signed-off-by:

Alexander Duyck <alexander.h.duyck@linux.intel.com> Signed-off-by:

Dan Williams <dan.j.williams@intel.com>

drivers/nvdimm/label.c

+2 −1

Original line number	Original line	Diff line number	Diff line
	@@ -75,7 +75,8 @@ size_t sizeof_namespace_index(struct nvdimm_drvdata *ndd)
	/*		/*
	* Per UEFI 2.7, the minimum size of the Label Storage Area is large		* Per UEFI 2.7, the minimum size of the Label Storage Area is large
	* enough to hold 2 index blocks and 2 labels. The minimum index		* enough to hold 2 index blocks and 2 labels. The minimum index
	* block size is 256 bytes, and the minimum label size is 256 bytes.		* block size is 256 bytes. The label size is 128 for namespaces
			* prior to version 1.2 and at minimum 256 for version 1.2 and later.
	*/		*/
	nslot = nvdimm_num_label_slots(ndd);		nslot = nvdimm_num_label_slots(ndd);
	space = ndd->nsarea.config_size - nslot * sizeof_namespace_label(ndd);		space = ndd->nsarea.config_size - nslot * sizeof_namespace_label(ndd);

Admin message