rtc: sa1100: fix unbalanced clk_prepare_enable/clk_disable_unprepare (1cf85b23) · Commits · 戴 / test

In the error path of sa1100_rtc_open(), info->clk is disabled which will happen again in sa1100_rtc_remove() when the module is removed whereas it is only enabled once in sa1100_rtc_init(). Fixes: ("drivers/rtc/rtc-sa1100.c: move clock enable/disable to probe/remove") Acked-by:

Robert Jarzmik <robert.jarzmik@free.fr> Signed-off-by:

Alexandre Belloni <alexandre.belloni@free-electrons.com>

drivers/rtc/rtc-sa1100.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -104,7 +104,7 @@ static int sa1100_rtc_open(struct device *dev)
		ret = request_irq(info->irq_1hz, sa1100_rtc_interrupt, 0, "rtc 1Hz", dev);
		if (ret) {
		dev_err(dev, "IRQ %d already in use.\n", info->irq_1hz);
		goto fail_ui;
		return ret;
		}
		ret = request_irq(info->irq_alarm, sa1100_rtc_interrupt, 0, "rtc Alrm", dev);
		if (ret) {
		@@ -118,8 +118,6 @@ static int sa1100_rtc_open(struct device *dev)

		fail_ai:
		free_irq(info->irq_1hz, dev);
		fail_ui:
		clk_disable_unprepare(info->clk);
		return ret;
		}

Admin message