Commit 1cf29cf4 authored by Todd Kjos's avatar Todd Kjos Committed by Greg Kroah-Hartman
Browse files

binder: remove binder_debug_no_lock mechanism 



With the global lock, there was a mechanism to access
binder driver debugging information with the global
lock disabled to debug deadlocks or other issues.
This mechanism is rarely (if ever) used anymore
and wasn't needed during the development of
fine-grained locking in the binder driver.
Removing it.

Signed-off-by: default avatarTodd Kjos <tkjos@google.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0c972a05

drivers/android/binder.c

+8 −23
Original line number Diff line number Diff line
@@ -107,9 +107,6 @@ static uint32_t binder_debug_mask = BINDER_DEBUG_USER_ERROR | 
	BINDER_DEBUG_FAILED_TRANSACTION | BINDER_DEBUG_DEAD_TRANSACTION;

module_param_named(debug_mask, binder_debug_mask, uint, S_IWUSR | S_IRUGO);



static bool binder_debug_no_lock;

module_param_named(proc_no_lock, binder_debug_no_lock, bool, S_IWUSR | S_IRUGO);



static char *binder_devices_param = CONFIG_ANDROID_BINDER_DEVICES;

module_param_named(devices, binder_devices_param, charp, 0444);
@@ -3507,9 +3504,7 @@ static int binder_state_show(struct seq_file *m, void *unused) 
{

	struct binder_proc *proc;

	struct binder_node *node;

	int do_lock = !binder_debug_no_lock;



	if (do_lock)

	binder_lock(__func__);



	seq_puts(m, "binder state:\n");
@@ -3521,7 +3516,6 @@ static int binder_state_show(struct seq_file *m, void *unused) 


	hlist_for_each_entry(proc, &binder_procs, proc_node)

		print_binder_proc(m, proc, 1);

	if (do_lock)

	binder_unlock(__func__);

	return 0;

}
@@ -3529,9 +3523,7 @@ static int binder_state_show(struct seq_file *m, void *unused) 
static int binder_stats_show(struct seq_file *m, void *unused)

{

	struct binder_proc *proc;

	int do_lock = !binder_debug_no_lock;



	if (do_lock)

	binder_lock(__func__);



	seq_puts(m, "binder stats:\n");
@@ -3540,7 +3532,6 @@ static int binder_stats_show(struct seq_file *m, void *unused) 


	hlist_for_each_entry(proc, &binder_procs, proc_node)

		print_binder_proc_stats(m, proc);

	if (do_lock)

	binder_unlock(__func__);

	return 0;

}
@@ -3548,15 +3539,12 @@ static int binder_stats_show(struct seq_file *m, void *unused) 
static int binder_transactions_show(struct seq_file *m, void *unused)

{

	struct binder_proc *proc;

	int do_lock = !binder_debug_no_lock;



	if (do_lock)

	binder_lock(__func__);



	seq_puts(m, "binder transactions:\n");

	hlist_for_each_entry(proc, &binder_procs, proc_node)

		print_binder_proc(m, proc, 0);

	if (do_lock)

	binder_unlock(__func__);

	return 0;

}
@@ -3565,9 +3553,7 @@ static int binder_proc_show(struct seq_file *m, void *unused) 
{

	struct binder_proc *itr;

	int pid = (unsigned long)m->private;

	int do_lock = !binder_debug_no_lock;



	if (do_lock)

	binder_lock(__func__);



	hlist_for_each_entry(itr, &binder_procs, proc_node) {
@@ -3576,7 +3562,6 @@ static int binder_proc_show(struct seq_file *m, void *unused) 
			print_binder_proc(m, itr, 1);

		}

	}

	if (do_lock)

	binder_unlock(__func__);

	return 0;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE