Commit 1cea4734 authored by Bartosz Golaszewski's avatar Bartosz Golaszewski Committed by Linus Walleij
Browse files

gpio: mockup: group code by logic 



Keep GPIO chip callbacks, event trigger callbacks and mockup chip
setup code visibly separated. We're mostly good - just need to move
the line naming routine below.

Signed-off-by: default avatarBartosz Golaszewski <brgl@bgdev.pl>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 5b7908c0

drivers/gpio/gpio-mockup.c

+23 −23
Original line number Diff line number Diff line
@@ -123,29 +123,6 @@ static int gpio_mockup_get_direction(struct gpio_chip *gc, unsigned int offset) 
	return chip->lines[offset].dir;

}



static int gpio_mockup_name_lines(struct device *dev,

				  struct gpio_mockup_chip *chip)

{

	struct gpio_chip *gc = &chip->gc;

	char **names;

	int i;



	names = devm_kcalloc(dev, gc->ngpio, sizeof(char *), GFP_KERNEL);

	if (!names)

		return -ENOMEM;



	for (i = 0; i < gc->ngpio; i++) {

		names[i] = devm_kasprintf(dev, GFP_KERNEL,

					  "%s-%d", gc->label, i);

		if (!names[i])

			return -ENOMEM;

	}



	gc->names = (const char *const *)names;



	return 0;

}



static int gpio_mockup_to_irq(struct gpio_chip *gc, unsigned int offset)

{

	struct gpio_mockup_chip *chip = gpiochip_get_data(gc);
@@ -238,6 +215,29 @@ err: 
	dev_err(dev, "error creating debugfs directory\n");

}



static int gpio_mockup_name_lines(struct device *dev,

				  struct gpio_mockup_chip *chip)

{

	struct gpio_chip *gc = &chip->gc;

	char **names;

	int i;



	names = devm_kcalloc(dev, gc->ngpio, sizeof(char *), GFP_KERNEL);

	if (!names)

		return -ENOMEM;



	for (i = 0; i < gc->ngpio; i++) {

		names[i] = devm_kasprintf(dev, GFP_KERNEL,

					  "%s-%d", gc->label, i);

		if (!names[i])

			return -ENOMEM;

	}



	gc->names = (const char *const *)names;



	return 0;

}



static int gpio_mockup_probe(struct platform_device *pdev)

{

	struct gpio_mockup_platform_data *pdata;

CRA Git | Maintained and supported by SUSTech CRA and CCSE