Commit 1ce53368 authored Jun 13, 2011 by Benjamin Marzinski Committed by Steven Whitehouse Jul 12, 2011

GFS2: force a log flush when invalidating the rindex glock



Right now, there is nothing that forces the log to get flushed when a node
drops its rindex glock so that another node can grow the filesystem. If the
log doesn't get flushed, GFS2 can corrupt the sd_log_le_rg list in the
following way.

A node puts an rgd on the list in rg_lo_add(), and then the rindex glock is
dropped so the other node can grow the filesystem. When the node reacquires the
rindex glock, that rgd gets deleted in clear_rgrpdi() before ever being
removed from the list by gfs2_log_flush().

This code simply forces a log flush when the rindex glock is invalidated,
solving the problem.

Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>

parent 620917de

fs/gfs2/glops.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -221,8 +221,10 @@ static void inode_go_inval(struct gfs2_glock *gl, int flags)
		}
		}

		if (ip == GFS2_I(gl->gl_sbd->sd_rindex))
		if (ip == GFS2_I(gl->gl_sbd->sd_rindex)) {
		gfs2_log_flush(gl->gl_sbd, NULL);
		gl->gl_sbd->sd_rindex_uptodate = 0;
		}
		if (ip && S_ISREG(ip->i_inode.i_mode))
		truncate_inode_pages(ip->i_inode.i_mapping, 0);
		}

Admin message