Commit 1cd9cb05 authored by Trond Myklebust's avatar Trond Myklebust
Browse files

NFS: Only look at the change attribute cache state in nfs_check_verifier 



When looking at whether or not our dcache is valid, we really don't care
about the general state of the directory attribute cache. Instead, we
we only care about the state of the change attribute.

This fixes a performance issue when the client is responsible for
changing the directory contents; a number of NFSv4 operations will
atomically update the directory change attribute, but may not return
all the other attributes.

Signed-off-by: default avatarTrond Myklebust <trond.myklebust@primarydata.com>
parent 9310b224

fs/nfs/dir.c

+6 −8
Original line number Original line Diff line number Diff line
@@ -1030,8 +1030,6 @@ EXPORT_SYMBOL_GPL(nfs_force_lookup_revalidate); 
static int nfs_check_verifier(struct inode *dir, struct dentry *dentry,

static int nfs_check_verifier(struct inode *dir, struct dentry *dentry,

			      int rcu_walk)

			      int rcu_walk)

{

{

	int ret;



	if (IS_ROOT(dentry))

	if (IS_ROOT(dentry))

		return 1;

		return 1;

	if (NFS_SERVER(dir)->flags & NFS_MOUNT_LOOKUP_CACHE_NONE)

	if (NFS_SERVER(dir)->flags & NFS_MOUNT_LOOKUP_CACHE_NONE)
@@ -1039,12 +1037,12 @@ static int nfs_check_verifier(struct inode *dir, struct dentry *dentry, 
	if (!nfs_verify_change_attribute(dir, dentry->d_time))

	if (!nfs_verify_change_attribute(dir, dentry->d_time))

		return 0;

		return 0;

	/* Revalidate nfsi->cache_change_attribute before we declare a match */

	/* Revalidate nfsi->cache_change_attribute before we declare a match */

	if (nfs_mapping_need_revalidate_inode(dir)) {

		if (rcu_walk)

		if (rcu_walk)

		ret = nfs_revalidate_inode_rcu(NFS_SERVER(dir), dir);

	else

		ret = nfs_revalidate_inode(NFS_SERVER(dir), dir);

	if (ret < 0)

			return 0;

			return 0;

		if (__nfs_revalidate_inode(NFS_SERVER(dir), dir) < 0)

			return 0;

	}

	if (!nfs_verify_change_attribute(dir, dentry->d_time))

	if (!nfs_verify_change_attribute(dir, dentry->d_time))

		return 0;

		return 0;

	return 1;

	return 1;

fs/nfs/inode.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -1112,7 +1112,7 @@ static int nfs_invalidate_mapping(struct inode *inode, struct address_space *map 
	return 0;

	return 0;

}

}





static bool nfs_mapping_need_revalidate_inode(struct inode *inode)

bool nfs_mapping_need_revalidate_inode(struct inode *inode)

{

{

	unsigned long cache_validity = NFS_I(inode)->cache_validity;

	unsigned long cache_validity = NFS_I(inode)->cache_validity;

include/linux/nfs_fs.h

+1 −0
Original line number Original line Diff line number Diff line
@@ -345,6 +345,7 @@ extern int nfs_attribute_cache_expired(struct inode *inode); 
extern int nfs_revalidate_inode(struct nfs_server *server, struct inode *inode);

extern int nfs_revalidate_inode(struct nfs_server *server, struct inode *inode);

extern int nfs_revalidate_inode_rcu(struct nfs_server *server, struct inode *inode);

extern int nfs_revalidate_inode_rcu(struct nfs_server *server, struct inode *inode);

extern int __nfs_revalidate_inode(struct nfs_server *, struct inode *);

extern int __nfs_revalidate_inode(struct nfs_server *, struct inode *);

extern bool nfs_mapping_need_revalidate_inode(struct inode *inode);

extern int nfs_revalidate_mapping(struct inode *inode, struct address_space *mapping);

extern int nfs_revalidate_mapping(struct inode *inode, struct address_space *mapping);

extern int nfs_revalidate_mapping_rcu(struct inode *inode);

extern int nfs_revalidate_mapping_rcu(struct inode *inode);

extern int nfs_setattr(struct dentry *, struct iattr *);

extern int nfs_setattr(struct dentry *, struct iattr *);

CRA Git | Maintained and supported by SUSTech CRA and CCSE