Commit 1cd11064 authored Sep 20, 2016 by Lijun Ou Committed by Doug Ledford Oct 03, 2016

IB/hns: Fix bug of memory leakage for registering user mr



While the page size attribute of umem is illegal, we should release
umem that get by ib_umem_get interface.

Also, we should return a non-zero value while pbl number is wrong.

Signed-off-by: Lijun Ou <oulijun@huawei.com>
Signed-off-by: Dongdong Huang(Donald) <hdd.huang@huawei.com>
Reviewed-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>

parent 49fdf6bb

drivers/infiniband/hw/hns/hns_roce_mr.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -564,11 +564,14 @@ struct ib_mr hns_roce_reg_user_mr(struct ib_pd pd, u64 start, u64 length,
		if (mr->umem->page_size != HNS_ROCE_HEM_PAGE_SIZE) {
		dev_err(dev, "Just support 4K page size but is 0x%x now!\n",
		mr->umem->page_size);
		ret = -EINVAL;
		goto err_umem;
		}

		if (n > HNS_ROCE_MAX_MTPT_PBL_NUM) {
		dev_err(dev, " MR len %lld err. MR is limited to 4G at most!\n",
		length);
		ret = -EINVAL;
		goto err_umem;
		}

Admin message