Commit 1cbc36a5 authored Aug 03, 2018 by Dan Carpenter Committed by David S. Miller Aug 05, 2018

net: sched: cls_flower: Fix an error code in fl_tmplt_create()

We forgot to set the error code on this path, so we return NULL instead
of an error pointer. In the current code kzalloc() won't fail for small
allocations so this doesn't really affect runtime.

Fixes: b95ec7eb ("net: sched: cls_flower: implement chain templates")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent a6bcfc89

net/sched/cls_flower.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1250,8 +1250,10 @@ static void fl_tmplt_create(struct net net, struct tcf_chain *chain,
		goto errout_tb;

		tmplt = kzalloc(sizeof(*tmplt), GFP_KERNEL);
		if (!tmplt)
		if (!tmplt) {
		err = -ENOMEM;
		goto errout_tb;
		}
		tmplt->chain = chain;
		err = fl_set_key(net, tb, &tmplt->dummy_key, &tmplt->mask, extack);
		if (err)

Admin message