Commit 1cbbd85f authored Mar 02, 2019 by Colin Ian King Committed by Benjamin Tissoires Mar 11, 2019

HID: uclogic: remove redudant duplicated null check on ver_ptr



Currently ver_ptr is being null checked twice, once before calling
usb_string and once afterwards.  The second null check is redundant
and can be removed, remove it.

Detected by CoverityScan, CID#1477308 ("Logically dead code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

parent 78b92f5f

drivers/hid/hid-uclogic-params.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -735,10 +735,6 @@ static int uclogic_params_huion_init(struct uclogic_params *params,
		goto cleanup;
		}
		rc = usb_string(udev, 201, ver_ptr, ver_len);
		if (ver_ptr == NULL) {
		rc = -ENOMEM;
		goto cleanup;
		}
		if (rc == -EPIPE) {
		*ver_ptr = '\0';
		} else if (rc < 0) {

Admin message