Commit 1cb6610a authored by Linus Walleij's avatar Linus Walleij
Browse files

gpio: dln2: Include proper header 



This driver has no business including <linux/gpio.h>, it is a
driver so include <linux/gpio/driver.h>.

GPIOF_DIR_IN/GPIOF_DIR_OUT are for consumers and should not be
used in drivers to use just 1/0 instead.

Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 95260c17

drivers/gpio/gpio-dln2.c

+3 −4
Original line number Diff line number Diff line
@@ -15,7 +15,6 @@ 
#include <linux/irqdomain.h>

#include <linux/irq.h>

#include <linux/irqchip/chained_irq.h>

#include <linux/gpio.h>

#include <linux/gpio/driver.h>

#include <linux/platform_device.h>

#include <linux/mfd/dln2.h>
@@ -204,9 +203,9 @@ static int dln2_gpio_get_direction(struct gpio_chip *chip, unsigned offset) 
	struct dln2_gpio *dln2 = gpiochip_get_data(chip);



	if (test_bit(offset, dln2->output_enabled))

		return GPIOF_DIR_OUT;

		return 0;



	return GPIOF_DIR_IN;

	return 1;

}



static int dln2_gpio_get(struct gpio_chip *chip, unsigned int offset)
@@ -218,7 +217,7 @@ static int dln2_gpio_get(struct gpio_chip *chip, unsigned int offset) 
	if (dir < 0)

		return dir;



	if (dir == GPIOF_DIR_IN)

	if (dir == 1)

		return dln2_gpio_pin_get_in_val(dln2, offset);



	return dln2_gpio_pin_get_out_val(dln2, offset);

CRA Git | Maintained and supported by SUSTech CRA and CCSE