Commit 1ca018d2 authored Jun 17, 2015 by Trond Myklebust

pNFS: Fix a memory leak when attempted pnfs fails



pnfs_do_write() expects the call to pnfs_write_through_mds() to free the
pgio header and to release the layout segment before exiting. The problem
is that nfs_pgio_data_destroy() doesn't actually do this; it only frees
the memory allocated by nfs_generic_pgio().

Ditto for pnfs_do_read()...

Fix in both cases is to add a call to hdr->release(hdr).

Cc: stable@vger.kernel.org
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>

parent 4e54ab8d

fs/nfs/pnfs.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1865,6 +1865,7 @@ pnfs_write_through_mds(struct nfs_pageio_descriptor *desc,
		mirror->pg_recoalesce = 1;
		}
		nfs_pgio_data_destroy(hdr);
		hdr->release(hdr);
		}

		static enum pnfs_try_status
		@@ -1979,6 +1980,7 @@ pnfs_read_through_mds(struct nfs_pageio_descriptor *desc,
		mirror->pg_recoalesce = 1;
		}
		nfs_pgio_data_destroy(hdr);
		hdr->release(hdr);
		}

		/*

Admin message