Commit 1c9f0471 authored Jun 12, 2014 by Victor Kamensky Committed by Christoffer Dall Jul 11, 2014

ARM: KVM: vgic mmio should hold data as LE bytes array in BE case



According to recent clarifications of mmio.data array meaning -
the mmio.data array should hold bytes as they would appear in
memory. Vgic is little endian device. And in case of BE image
kernel side that emulates vgic, holds data in BE form. So we
need to byteswap cpu<->le32 vgic registers when we read/write them
from mmio.data[].

Change has no effect in LE case because cpu already runs in le32.

Signed-off-by: Victor Kamensky <victor.kamensky@linaro.org>
Reviewed-by: Christoffer Dall <christoffer.dall@linaro.org>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>

parent 6d7311b5

virt/kvm/arm/vgic.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -238,12 +238,12 @@ static void vgic_cpu_irq_clear(struct kvm_vcpu *vcpu, int irq)

		static u32 mmio_data_read(struct kvm_exit_mmio *mmio, u32 mask)
		{
		return ((u32 )mmio->data) & mask;
		return le32_to_cpu(((u32 )mmio->data)) & mask;
		}

		static void mmio_data_write(struct kvm_exit_mmio *mmio, u32 mask, u32 value)
		{
		((u32 )mmio->data) = value & mask;
		((u32 )mmio->data) = cpu_to_le32(value) & mask;
		}

		/**

Admin message