usb: dwc3: ep0: avoid empty-body warning (1c404b51) · Commits · 戴 / test

Building with W=1, we get a warning about harmless empty statements: drivers/usb/dwc3/ep0.c: In function 'dwc3_ep0_handle_intf': drivers/usb/dwc3/ep0.c:491:4: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body] Instead of adding empty braces which would introduce checkpatch.pl warnings, we're just removing the code which doesn't do anything and making sure we return 0 so USBCV tool is happy. Signed-off-by:

Arnd Bergmann <arnd@arndb.de> Signed-off-by:

Felipe Balbi <felipe.balbi@linux.intel.com>

drivers/usb/dwc3/ep0.c

+7 −6

Original line number	Original line	Diff line number	Diff line
	@@ -486,12 +486,13 @@ static int dwc3_ep0_handle_intf(struct dwc3 *dwc,

	switch (wValue) {		switch (wValue) {
	case USB_INTRF_FUNC_SUSPEND:		case USB_INTRF_FUNC_SUSPEND:
	if (wIndex & USB_INTRF_FUNC_SUSPEND_LP)		/*
	/* XXX enable Low power suspend */		* REVISIT: Ideally we would enable some low power mode here,
	;		* however it's unclear what we should be doing here.
	if (wIndex & USB_INTRF_FUNC_SUSPEND_RW)		*
	/* XXX enable remote wakeup */		* For now, we're not doing anything, just making sure we return
	;		* 0 so USB Command Verifier tests pass without any errors.
			*/
	break;		break;
	default:		default:
	ret = -EINVAL;		ret = -EINVAL;

Admin message