Commit 1c38d03e authored Aug 12, 2015 by H Hartley Sweeten Committed by Greg Kroah-Hartman Aug 14, 2015

staging: comedi: hwdrv_apci3501: remove "magic" numbers in apci3501_read_insn_timer()



Use register bit defines from addi_tcw.h to remove the "magic" numbers.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 0d5e0307

drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -133,7 +133,8 @@ static int apci3501_read_insn_timer(struct comedi_device *dev,
		devpriv->timer_mode != ADDIDATA_WATCHDOG)
		return -EINVAL;

		data[0] = inl(devpriv->tcw + ADDI_TCW_STATUS_REG) & 0x1;
		data[0] = inl(devpriv->tcw + ADDI_TCW_STATUS_REG) &
		ADDI_TCW_STATUS_OVERFLOW;
		data[1] = inl(devpriv->tcw + ADDI_TCW_VAL_REG);

		return insn->n;

Admin message