Commit 1c24d06f authored Jun 04, 2010 by Jan Kara Committed by David Woodhouse Jun 06, 2010

jffs2: update ctime when changing the file's permission by setfacl



jffs2 didn't update the ctime of the file when its permission was changed.

Steps to reproduce:
 # touch aaa
 # stat -c %Z aaa
 1275289822
 # setfacl -m  'u::x,g::x,o::x' aaa
 # stat -c %Z aaa
 1275289822                         <- unchanged

But, according to the spec of the ctime, jffs2 must update it.

Port of ext3 patch by Miao Xie <miaox@cn.fujitsu.com>.

Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>

parent e72e6497

fs/jffs2/acl.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -234,8 +234,9 @@ static int jffs2_set_acl(struct inode inode, int type, struct posix_acl acl)
		if (inode->i_mode != mode) {
		struct iattr attr;

		attr.ia_valid = ATTR_MODE;
		attr.ia_valid = ATTR_MODE \| ATTR_CTIME;
		attr.ia_mode = mode;
		attr.ia_ctime = CURRENT_TIME_SEC;
		rc = jffs2_do_setattr(inode, &attr);
		if (rc < 0)
		return rc;

Admin message