Commit 1c1ada37 authored Jun 17, 2020 by Alex Deucher

drm/amdkfd: fix ref count leak when pm_runtime_get_sync fails



The call to pm_runtime_get_sync increments the counter even in case of
failure, leading to incorrect ref count.
In case of failure, decrement the ref count before returning.

Reviewed-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

parent e520d3e0

drivers/gpu/drm/amd/amdkfd/kfd_process.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1116,9 +1116,11 @@ struct kfd_process_device kfd_bind_process_to_device(struct kfd_dev dev,
		*/
		if (!pdd->runtime_inuse) {
		err = pm_runtime_get_sync(dev->ddev->dev);
		if (err < 0)
		if (err < 0) {
		pm_runtime_put_autosuspend(dev->ddev->dev);
		return ERR_PTR(err);
		}
		}

		err = kfd_iommu_bind_process_to_device(pdd);
		if (err)

Admin message