usb: renesas_usbhs: replace udelay() with usleep_range() (1c1a3dda) · Commits · 戴 / test

According to Documentation/timers/timers-howto.txt, a driver should use usleep_range() instead of udelay() on NON-ATOMIC CONTEXT if "SLEEPING FOR ~USECS OR SMALL MSECS ( 10us - 20ms)". Since the .hardware_init() and .power_ctrl() will run on NON-ATOMIC CONTEXT, this patch replaces udelay() with usleep_range(). Reviewed-by:

Simon Horman <horms+renesas@verge.net.au> Signed-off-by:

Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Signed-off-by:

Felipe Balbi <felipe.balbi@linux.intel.com>

drivers/usb/renesas_usbhs/rcar3.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -59,7 +59,7 @@ static int usbhs_rcar3_power_ctrl(struct platform_device *pdev,
		if (enable) {
		usbhs_bset(priv, LPSTS, LPSTS_SUSPM, LPSTS_SUSPM);
		/* The controller on R-Car Gen3 needs to wait up to 45 usec */
		udelay(45);
		usleep_range(45, 90);
		} else {
		usbhs_bset(priv, LPSTS, LPSTS_SUSPM, 0);
		}

drivers/usb/renesas_usbhs/rza.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -35,7 +35,7 @@ static int usbhs_rza1_hardware_init(struct platform_device *pdev)

		/* Enable USB PLL (NOTE: ch0 controls both ch0 and ch1) */
		usbhs_bset(priv, SYSCFG, UPLLE, UPLLE);
		udelay(1000);
		usleep_range(1000, 2000);
		usbhs_bset(priv, SUSPMODE, SUSPM, SUSPM);

		return 0;

Admin message