Commit 1c16a186 authored by Xin Long's avatar Xin Long Committed by Jakub Kicinski
Browse files

sctp: handle the init chunk matching an existing asoc 



This is from Section 4 of draft-tuexen-tsvwg-sctp-udp-encaps-cons-03,
and it requires responding with an abort chunk with an error cause
when the udp source port of the received init chunk doesn't match the
encap port of the transport.

Signed-off-by: default avatarXin Long <lucien.xin@gmail.com>
Acked-by: default avatarMarcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent e38d86b3

net/sctp/sm_statefuns.c

+50 −0
Original line number Diff line number Diff line
@@ -87,6 +87,13 @@ static enum sctp_disposition sctp_sf_tabort_8_4_8( 
					const union sctp_subtype type,

					void *arg,

					struct sctp_cmd_seq *commands);

static enum sctp_disposition sctp_sf_new_encap_port(

					struct net *net,

					const struct sctp_endpoint *ep,

					const struct sctp_association *asoc,

					const union sctp_subtype type,

					void *arg,

					struct sctp_cmd_seq *commands);

static struct sctp_sackhdr *sctp_sm_pull_sack(struct sctp_chunk *chunk);



static enum sctp_disposition sctp_stop_t1_and_abort(
@@ -1493,6 +1500,10 @@ static enum sctp_disposition sctp_sf_do_unexpected_init( 
	if (!sctp_chunk_length_valid(chunk, sizeof(struct sctp_init_chunk)))

		return sctp_sf_violation_chunklen(net, ep, asoc, type, arg,

						  commands);



	if (SCTP_INPUT_CB(chunk->skb)->encap_port != chunk->transport->encap_port)

		return sctp_sf_new_encap_port(net, ep, asoc, type, arg, commands);



	/* Grab the INIT header.  */

	chunk->subh.init_hdr = (struct sctp_inithdr *)chunk->skb->data;
@@ -3392,6 +3403,45 @@ static enum sctp_disposition sctp_sf_tabort_8_4_8( 


	sctp_packet_append_chunk(packet, abort);



	sctp_add_cmd_sf(commands, SCTP_CMD_SEND_PKT, SCTP_PACKET(packet));



	SCTP_INC_STATS(net, SCTP_MIB_OUTCTRLCHUNKS);



	sctp_sf_pdiscard(net, ep, asoc, type, arg, commands);

	return SCTP_DISPOSITION_CONSUME;

}



/* Handling of SCTP Packets Containing an INIT Chunk Matching an

 * Existing Associations when the UDP encap port is incorrect.

 *

 * From Section 4 at draft-tuexen-tsvwg-sctp-udp-encaps-cons-03.

 */

static enum sctp_disposition sctp_sf_new_encap_port(

					struct net *net,

					const struct sctp_endpoint *ep,

					const struct sctp_association *asoc,

					const union sctp_subtype type,

					void *arg,

					struct sctp_cmd_seq *commands)

{

	struct sctp_packet *packet = NULL;

	struct sctp_chunk *chunk = arg;

	struct sctp_chunk *abort;



	packet = sctp_ootb_pkt_new(net, asoc, chunk);

	if (!packet)

		return SCTP_DISPOSITION_NOMEM;



	abort = sctp_make_new_encap_port(asoc, chunk);

	if (!abort) {

		sctp_ootb_pkt_free(packet);

		return SCTP_DISPOSITION_NOMEM;

	}



	abort->skb->sk = ep->base.sk;



	sctp_packet_append_chunk(packet, abort);



	sctp_add_cmd_sf(commands, SCTP_CMD_SEND_PKT,

			SCTP_PACKET(packet));

CRA Git | Maintained and supported by SUSTech CRA and CCSE