Commit 1be7892f authored Mar 27, 2006 by NeilBrown Committed by Linus Torvalds Mar 27, 2006

[PATCH] md: Fix the 'failed' count for version-0 superblocks



We are counting failed devices twice, once of the device that is failed, and
once for the hole that has been left in the array.  Remove the former so
'failed' matches 'missing'.  Storing these counts in the superblock is a bit
silly anyway....

Signed-off-by: Neil Brown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent c5a10f62

drivers/md/md.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -895,10 +895,9 @@ static void super_90_sync(mddev_t mddev, mdk_rdev_t rdev)
		d->raid_disk = rdev2->raid_disk;
		else
		d->raid_disk = rdev2->desc_nr; /* compatibility */
		if (test_bit(Faulty, &rdev2->flags)) {
		if (test_bit(Faulty, &rdev2->flags))
		d->state = (1<<MD_DISK_FAULTY);
		failed++;
		} else if (test_bit(In_sync, &rdev2->flags)) {
		else if (test_bit(In_sync, &rdev2->flags)) {
		d->state = (1<<MD_DISK_ACTIVE);
		d->state \|= (1<<MD_DISK_SYNC);
		active++;

Admin message