Commit 1be0eb2a authored May 06, 2016 by Peter Zijlstra Committed by Ingo Molnar May 12, 2016

sched/fair: Clean up scale confusion



Wanpeng noted that the scale_load_down() in calculate_imbalance() was
weird. I agree, it should be SCHED_CAPACITY_SCALE, since we're going
to compare against busiest->group_capacity, which is in [capacity]
units.

Reported-by: Wanpeng Li <wanpeng.li@hotmail.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Morten Rasmussen <morten.rasmussen@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Yuyang Du <yuyang.du@intel.com>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 44496922

kernel/sched/fair.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -7066,8 +7066,7 @@ static inline void calculate_imbalance(struct lb_env env, struct sd_lb_stats s
		*/
		if (busiest->group_type == group_overloaded &&
		local->group_type == group_overloaded) {
		load_above_capacity = busiest->sum_nr_running *
		scale_load_down(NICE_0_LOAD);
		load_above_capacity = busiest->sum_nr_running * SCHED_CAPACITY_SCALE;
		if (load_above_capacity > busiest->group_capacity)
		load_above_capacity -= busiest->group_capacity;
		else

Admin message