Commit 1bda18de authored Sep 05, 2016 by Colin Ian King Committed by Sagi Grimberg Sep 12, 2016

nvme-rdma: fix null pointer dereference on req->mr



If there is an error on req->mr, req->mr is set to null, however
the following statement sets req->mr->need_inval causing a null
pointer dereference.  Fix this by bailing out to label 'out' to
immediately return and hence skip over the offending null pointer
dereference.

Fixes: f5b7b559 ("nvme-rdma: Get rid of duplicate variable")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>

parent e87a911f

drivers/nvme/host/rdma.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -293,6 +293,7 @@ static int nvme_rdma_reinit_request(void data, struct request rq)
		if (IS_ERR(req->mr)) {
		ret = PTR_ERR(req->mr);
		req->mr = NULL;
		goto out;
		}

		req->mr->need_inval = false;

Admin message